Multiple applinks: Wrong suggestion to upgrade

Fix versions

Priority

Description

After https://playsql.atlassian.net/browse/ES-468#icft=ES-468
It is not clear if customer has several applinks or if there is something else.

In IntegrationManager, need to check this part.

for (ApplicationLink applink : applinks) { IntegrationDescriptor externalConnection = getDescriptor(applink); if (externalConnection.getUpgradeMode() != APIUpgradeMode.DISABLED) { if (externalConnection.getVersion() > 0) { // ?? why not checking also ConfluenceApplicationType results.add(externalConnection); } else if (applink.getType() instanceof ConfluenceApplicationType) { results.add(externalConnection); } } else if (withDisabled) { results.add(externalConnection); } }

Attachments

1
  • 03 Sep 2021, 03:41 PM

Activity

Show:

Adrien RagotFebruary 24, 2022 at 2:55 PM

I didn't succeed to reproduce, even with several applinks I'm still getting the correct behavior.

Laurent NonnenmacherSeptember 6, 2021 at 7:44 AM

But, what if there are more than 1 app link ?

Adrien RagotSeptember 3, 2021 at 3:41 PM

While working on it, I disagree:

  • If the app returns a value for getVersion(), it means the descriptor was once “upgraded” by Requirement Yogi, therefore the opposite app is a RY app. Therefore it is not necessary to check whether it is a ConfluenceApplicationType.

  • If the app is in V0, but is Confluence, then we display it.

  • If they don’t want the suggestion to upgrade, then they should just set it to “disabled”, since it doesn’t check whether it can be upgraded if it is disabled:

Therefore I don’t see what should be fixed in this issue.

I am planing to “Won’t fix” this issue. Do you agree?

Cheers,

Adrien

Cannot Reproduce

Details

Assignee

Reporter

Sprint

Story Points

Release date

Requirement Yogi

Created July 27, 2021 at 1:40 PM
Updated April 11, 2022 at 1:58 PM
Resolved February 24, 2022 at 2:55 PM